Author solution is incorrect: ultimaProb(["BEWD","BEWD","BEWD"],1,0,1) expects None. It can't handle the situation when initial hand has more than strictly enough of 1 ingredient but not the other.
Basically, it's never going to work (this can be verified by manually counting all the combinations) and needs to be rewritten if random tests are going to be added.
Same as anter69, but considering the number of tests, I concidere this an ISSUE, not just a suggestion!
Needs lots and lots of tests.
About anter69's suggestions:
the case info = ['this text', 'that text'] is already managed by the description with find among information the UNIQUE string that has the highest number of words in common with question.
the second one, info = ['text text', 'no text'] is already implicitly managed with the description too: the answer should be 'text text'. But that is not tested for now. you'll have to choose either to modify the description or add those type of tests.
This comment is hidden because it contains spoiler information about the solution
Add
[Code Golf]
to the kata titleScala translation
CoffeeScript translation
Author solution is incorrect:
ultimaProb(["BEWD","BEWD","BEWD"],1,0,1)
expectsNone
. It can't handle the situation when initial hand has more than strictly enough of 1 ingredient but not the other.Basically, it's never going to work (this can be verified by manually counting all the combinations) and needs to be rewritten if random tests are going to be added.
It's unclear whether each parameter includes the other parameters, e.g:
d
,b
andp
include the current hand?d
includeb
andp
?The kata needs random tests.
Please use new python test framework.
TypeScript Translation!
PHP Translation
Please Review And Approve ;)
This comment is hidden because it contains spoiler information about the solution
Same as anter69, but considering the number of tests, I concidere this an ISSUE, not just a suggestion!
Needs lots and lots of tests.
About anter69's suggestions:
info = ['this text', 'that text']
is already managed by the description withfind among information the UNIQUE string that has the highest number of words in common with question.
info = ['text text', 'no text']
is already implicitly managed with the description too: the answer should be 'text text'. But that is not tested for now. you'll have to choose either to modify the description or add those type of tests.Suggestions:
or:
This comment is hidden because it contains spoiler information about the solution
This comment is hidden because it contains spoiler information about the solution