Ad
  • Custom User Avatar
  • Custom User Avatar

    I got the impression from the reading I did ( had to do ) that we're being asked for a Julian Day, not a Julian Date. I may be wrong there; if anybody actually knows either way, please chime in.

    I didn't know about Julian Days. The description should have contained enough information ( and not necessarily more ) that I would not have had to Google "Julian Date" and read up, esp. the fact that a Julian Day is just a sequential number since a reference date. If you want or need to know more, it's acceptable to have to click through ( a link to Wikipedia would be nice ).

    This would be an 8 kyu kata in JavaScript but for the vagaries of Date. I don't know if it is your intention to have this kata being more about pointing out those vagaries than about Julian dates, in JavaScript. It's not necessarily a problem, I don't really know what to do about it either if you think it is, but it's exceedingly simple to convert dates if you know how to encode them in JS.

  • Custom User Avatar

    There are no false tests with n < 1.

  • Custom User Avatar

    There are no random tests.

  • Custom User Avatar

    Sample tests has the wrong function name.

  • Custom User Avatar

    missing edge case type: test.assert_equals(range_extractor([n]), 'range(n,n+1)') (with n>1 or n<0, ofc)

  • Custom User Avatar

    No random tests.

  • Custom User Avatar

    Returning different data types is a bad practice.

    In fact, I don't understand what's the point of returning a string instead of an actual range...