Ad
  • Custom User Avatar

    If anyone else has the same issues let me know.

  • Custom User Avatar

    Are you switching to solidity ^0.4.13 when moving the contract from local environment to online environment?

  • Custom User Avatar

    Can I get some specifics? I'm having trouble understanding the issue. Can you send me more info, like which one of the tests is broken and the error you are getting.

  • Custom User Avatar

    The getItem function should not ONLY be accessible by the owner. This function IF used in the real world (Do your own testing on your real world dapp's) would be hypothetically used to send all available items for sale to a potential buyer in a dapp. But really, this function was mainly made for testing purposes. So I don't think there is a need to throw errors or use event handlers. If you feel differently or if I totally misunderstood what you were saying, let me know.

  • Custom User Avatar

    Missing a closing bracket after your if statement to close out the sendGift function.

  • Custom User Avatar

    Using require would be better in this situation. So your code is "correct" but the kata's tests are wanting you to do something else.

  • Custom User Avatar

    Using require will throw an error if conditions are not met. Kata says "should detect when..." not "should throw error when...". So the kata doesn't want you to throw an error. It wants you to only do stuff when conditions are met, and do nothing when they are not.

  • Custom User Avatar

    Using require will throw an error if conditions are not met. Kata says "should detect when..." not "should throw error when...". So the kata doesn't want you to throw an error. It wants you to only do stuff when conditions are met, and do nothing when they are not.

  • Custom User Avatar

    I had this problem as well. If you just keep submitting your code it usually ends up working like the third or fourth time you submit it. It might take more times. Anyway this is an issue that needs to be fixed.

  • Custom User Avatar

    Hey, saw that your code passed without checking if the correct ether was sent on the above issue. Fixed my tests and now you should need to check for correct ether value to pass the kata.

  • Custom User Avatar

    Ok, done. Thanks.

  • Custom User Avatar

    In descripttion, addItem, number 3 says id shoud start with 1.

    Would Should throw error if incorrect ether value sent be good enough? I don't know what else it should be. When you send ether to a smart contract function you send it in an object with a key of value. Let me know. And thanks for the feedback.

  • Custom User Avatar

    There was a bug in one of the Test Cases. Thanks for the help!

  • Custom User Avatar

    Hmm... The solution in Python was made by FourthFan during translation. I wouldn't know how to fix it as a don't know Python. The JS version is working fine other than not being "real" random tests. Do you agree? And thanks for feedback and helping!

  • Custom User Avatar

    I don't use a random generator. They were made manually.

  • Loading more items...