Ad
  • Default User Avatar

    Hey Blind4Basics, I don't want to offend you personally and so would I urge you not to either. But I'll describe what made me downvote yesterday.

  • Custom User Avatar

    So, you're the kind of guy who downvote the other one who tries to help you? Maaaaaan, that's pretty fair, don't you think? Especially when that guy isn't even the author of the kata or the translation and just take on his time to help you...

    FYI, I just checked again, and the solution I used to replace the original one returns your """real convex hull""" as it should. So I don't know what is the problem, but I'm sure of one thing: this time it's on your side. I just changed one thing more, so that the expected value is computed before your function even touches to the data... Just in case you're actually mutating the input without even thinking about it and then reject the fault on someone else...?

  • Custom User Avatar

    Have you reset the kata? The current reference solution returns the second array ("real convex hull" as you call it).

  • Default User Avatar

    okay let me emphasize that every randomly generated testcase has a wrong solution. Here you have another example:
    ([points],[given solution],[Real convex hull]):
    ([[96, 56], [48, 33], [17, 73], [57, 7], [14, 17], [31, 46], [54, 47], [48, 95], [89, 96], [75, 15], [96, 87], [33, 69], [17, 41], [76, 97], [75, 99], [77, 20], [57, 52], [90, 41], [96, 83], [42, 26], [66, 84], [26, 33], [28, 45], [59, 76], [44, 9], [45, 53], [22, 33], [31, 62], [31, 94], [49, 92], [76, 60], [40, 37], [41, 70], [98, 18], [29, 78], [80, 25], [60, 6], [81, 56], [82, 24], [56, 26], [16, 83], [88, 75], [57, 9], [62, 7], [72, 12], [93, 48], [24, 79], [97, 17], [27, 41], [91, 44]],[[14, 17], [16, 83], [31, 94], [44, 9], [60, 6], [75, 99], [89, 96], [96, 87], [97, 17]],[[14, 17], [16, 83], [31, 94], [44, 9], [60, 6], [75, 99], [89, 96], [96, 87], [97, 17], [98, 18]])

  • Custom User Avatar

    Confirmed. Though, it seems you found a rare edge case, because I check the original solution against one that solves this case correctly and I couldn't make it fail. Well, I replaced the internal solution with the good one, should be good, now.

  • Default User Avatar

    Random test solutions appear to be wrong (python). one point is always missing, which belongs to the convex hull.
    e.g. ([points],[given solution],[Real convex hull]): ([[86, 42], [78, 14], [68, 22], [25, 66], [94, 10], [6, 40], [30, 9], [14, 63], [12, 80], [36, 60], [28, 15], [67, 39], [31, 36], [38, 76], [9, 49], [29, 59], [8, 70], [98, 83], [80, 96], [63, 27], [74, 10], [79, 69], [59, 9], [42, 80], [81, 59], [19, 39], [48, 35], [92, 34], [70, 33], [72, 84], [51, 56], [85, 56], [49, 66], [41, 95], [54, 43], [72, 64], [98, 82], [36, 30], [53, 22], [83, 27], [5, 52], [72, 21], [53, 88], [44, 33], [33, 81], [32, 21], [79, 8], [24, 80], [25, 97], [68, 19]],[[5, 52], [6, 40], [8, 70], [12, 80], [25, 97], [30, 9], [79, 8], [80, 96], [94, 10], [98, 82]],[[5, 52], [6, 40], [8, 70], [12, 80], [25, 97], [30, 9], [79, 8], [80, 96], [94, 10], [98, 82], [98, 83]])