Ad
  • Custom User Avatar

    Hi,

    • the specs are not matching the tests: 'S' should return None while it's supposed to be taken as 's'.
    • This has nothing to do with a date parser, this is a time converter.
    • why returning None when the value is negative? A negative timedelta makes sense.
    • The task as very little interest, and the DateParser class and its methods are totally useless => ?

    Cheers

  • Custom User Avatar

    This does not make much sense. Either you need the DateParse class or not? My solution does not have the class, but still passes tests. Tests verify correcthess of the preloaded class, and not of my class. Why? What exactly is tested? My class is not tested, because I do not have it.

  • Custom User Avatar

    in the description of Kata i sayd, you have class DateParser, and this class have list of function. You need create DateParse Function to optimize this class(

    in this Kata you need optimize class, but you also can make you own function without DateParser class function's.

  • Custom User Avatar

    What is DateParser, and why is it preloaded? Users do not have to implement it, so why is it tested?

  • Custom User Avatar
    • The message should be present also in fixed tests, not only in random tests.
    • Python naming convention for functions is snake_case date_parse and not DateParse.
  • Custom User Avatar

    sanks for your example, now work correct i think

  • Custom User Avatar

    okay, i go fix it

  • Custom User Avatar
    • Code style issue: variable names should really be better than aaa, bbb, and ccc. Please assign some meaningful names to the variables. first and second are also not very fortunate names, maybe something like from/to or source/target would be better?
    • UX/test style issue: failed tests should use failure messages to present inputs which cased failure. You can see example kata or Python authoring guide for examples.
  • Custom User Avatar

    Thank you, okay i fix all?

  • Custom User Avatar

    okay, None is the better solution, sanks

  • Custom User Avatar

    sory, i go fix it

  • Custom User Avatar

    -1 is a very bad choice design-wise. For Python, an error or None would be much better in my opinion.

  • Custom User Avatar

    Why is there Python code in Javascript translation? I think that Javascript was added by accident and needs to be removed.

  • Custom User Avatar

    and i think -50 seconds isn't correct. If we fantasy about this => okay, but in real this is uncorrect value, i think user can take a exception or False, but stopped at -1.

  • Custom User Avatar

    negative values not correct, i think -1 very nice solution. This kata for new members like 7-8 rang

  • Loading more items...