Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
approved
Approved by someone
yeah, most of the TS kata are old and using that wonky setup, unfortunately...
@MaGu: the TS setup you're using is outdated. The wrapping class is cumbersome and not used anymore, the TS version should be updated accordinlgy to current standards. See there for info about what to do: https://github.com/codewars/content-issues/wiki/List-of-TypeScript-Kata-to-Update
I'm not sure where to ask for help for reviewing translations so I've been approving them if they passed all tests.
OP, please have this translation reviewed by an experienced ( relevantly ) user. Translator has very little experience and is making rookie mistakes. ( That's not an insult, that's just a statement of fact. )
It is .. somewhat.
I've made a fork to show how I'd do it, changing as little as possible. Calculating
expected
andmessage
beforeactual
ensures those will be based on pristine arguments. I quite like that you explicitly check for input modification instead of letting solvers get away with it, but it needs clear failure messages; you are not testing what solver is expecting. Failure messages in general are a good idea. The JS framework makes it quite easy to have good ones.You can approve that fork, but it's very much intended for you to read and learn from ( the
Diff
tab is extremely useful! ). If you don't understand why I changed something, don't hesitate to ask.Some ( most? ) of this is documented, some ( most? ) of it you could have picked up reading other people's test suites, but we all had to learn. Friendly advice, worth what you paid for it: maybe focus on one language at a time, and learn more details, intricacies and peculiarities about that language's testing framework. There are quite some details ( though some will carry over between languages ) to authoring and translating kata.
This probably has the same input modification vulnerability as the JS version. If so, please fix it.
Please address Issue
Thank you so much for all the translations