Ad
  • Default User Avatar

    I'm lost between two indexes... I thought that while a real number might or might not be an integer, an integer was indeed a real number ...

  • Custom User Avatar
    • The index is a integer (real number).

    The index is not a real number, it's an integer. ( A real number is something else. ) If you mean it's always a valid index, you should say that, not "real number". But the next bullet point already says that, so I really don't know what you mean by "real number".

    • Double spaces may occur. Mention that.

    Remove "Mention that."

    an JS object

    That's "a" JS object, not "an". ( This is a very minor point, but while we're here .. )

    Also, now there can be double spaces ?!? I hope that's implemented correctly; I'm not solving this again.

  • Custom User Avatar
  • Custom User Avatar

    almost good, on my side. Just one tiny thing left: plz put the call the the ref solution in a different expression than th one calling to the users function=> define the epxected result before you call the user's soltuion. Once it's done, you can close the issue.

    Cheers

  • Custom User Avatar

    I fixed it. Now it has 20 predefined tests and 80 random tests with randomly 1 to 150 characters.

  • Custom User Avatar

    As in the reply above... Is it better? or would you suggest another wording? Thank you very much.

  • Custom User Avatar

    Sorry, I'm not a native english speaking person. I just rewrote the description. Is it better now?

  • Custom User Avatar

    Sorry, was the example code. I deleted it.

  • Custom User Avatar

    Initial code is

    // return the two oldest/oldest ages within the array of ages passed in.
    // it should return the two ages as a sorted array, youngest age first
    function findWord(input, index){
    
    }
    

    What is this?

  • Custom User Avatar

    Specialchars like - , ' ! ? : . are in the tests and should be added to the result text.

    ( my emphasis )

    There are no other specialchars used.

    These sentences are contradictory. The enumeration in the first sentence should be exhaustive for the second sentence to make sense.

  • Custom User Avatar

    A "JSON object" might be a string representation of an object ( that's what JSON is for ). You want to specify a regular JS Object object and prevent that confusion.

    Double spaces can't occur. It would be nice to mention that.

    There is no real difference between letters and special characters; only spaces and the rest matters. You might as well simplify the description on this point.

  • Custom User Avatar

    My. Poor. Browser. !!!

    Really, 100 random tests is enough, and have some smaller ones first and some larger ones later.

  • Custom User Avatar

    done, but see issue above

  • Custom User Avatar

    btw: the usual way around here, unless you're absolutely sure about what you do, is to wait for feeback before closing the issue.

    (that may have avoid to me the opening of this one)

  • Custom User Avatar

    Hi again,

    • When I said "more tests", I wasn't talking about 1000 of them... 'x) 100 are generally enough. Especially now that you removed all the possible edge cases. And you don't need to wrap each single tests in its own it block. That has only interest if you use the bolck to give the input. Otherwise, just wrap all the tests in one single it block
    • your random inputs always have the same length. "Huge" one.
      • There is no point for this size (it just makes the debugging harder for the user)
      • that means strings of one word only will never be tested => bad idea
      • that means ther is no chances to generate values of i at the very beginning or the very end (corener cases checks)
    • you removed all fixed tests from the full test suite (or did I miss the fact you didn't pu any right at the beginning?) => you need fixed tests before the random tests.
    • I forgot to mention that it's not specified if i will always be a valid index of the sentence (apprently, it will)
    • about those fixed tests, be sure you test:
      • sentences of one single word
      • i=0
      • i=input.length-1

    Did you consider reading the authoring documentation...? Because all of this is explained there.

    cheers

  • Loading more items...