Didn't solve the kata in java, but good to know that for the future. I'm guessing the translation fork being out-of-sync with the kata caused my fork to show differences in description, as if I've removed many lines from it.
However, there is a breaking change: in JUnit 5, the optional message argument comes third, not first like in JUnit 4.
Otherwise, I can approve now.
(Note that if you solved the kata in Java, it is better to fork the kata directly, instead of forking a previous fork/translation like you did there, as it pulls the latest version of the kata, while a previous fork/translation can become out-of-sync if either it or the kata gets edited. Disregard this if you did not solve the kata in Java)
Had to also change the solution a bit, because previously with empty string as the argument, it returned an array, that contained one empty string (instead of an empty array).
Upgraded to JUnit 5.
Didn't solve the kata in java, but good to know that for the future. I'm guessing the translation fork being out-of-sync with the kata caused my fork to show differences in description, as if I've removed many lines from it.
If you feel like it, this is a good opportunity to upgrade to JUnit 5. The imports become:
However, there is a breaking change: in JUnit 5, the optional
message
argument comes third, not first like in JUnit 4.Otherwise, I can approve now.
(Note that if you solved the kata in Java, it is better to fork the kata directly, instead of forking a previous fork/translation like you did there, as it pulls the latest version of the kata, while a previous fork/translation can become out-of-sync if either it or the kata gets edited. Disregard this if you did not solve the kata in Java)
Had to also change the solution a bit, because previously with empty string as the argument, it returned an array, that contained one empty string (instead of an empty array).
right? i test it too. it not work with last test
Doesn't work for:
$this->assertEquals([], solution(""));
You are missing random tests.
Approved
strlen counts ç,ş,ü,ğ as 2. so its better to use mb_strlen or convert it to an array then count.
Hi,
I translated your Kata in Java language.
What do you think about it?
Hi,
I translated your Kata in Java language.
What do you think about it?