Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Unpublishing because:
This comment is hidden because it contains spoiler information about the solution
took 16ms to run :)
This is a built-in feature of most languages.
Thanks
It's an empty string (that's why you can't see it).
It doesn't show the last one, it only shows 9 attempts of 10 on the console, when I do console.log(str), and the one that doesn't show is the that's wrong
Use
console.log
to check what the input value is in that case, fix your code.This comment is hidden because it contains spoiler information about the solution
You need random testing. Good random testing. Not just tests that always expect
true
, not just integers, a true mixed bag.You need edge cases. Numbers of the form
1e3
shouldn't have been an edge case, but by ignoring them initially, you made them an edge case. Testing with0
is conspicuously lacking as well; people are even commenting on their own solution about that. Random tests can help you find more edge cases; you then add fixed tests for these. ( Ideally, when people submit a solution that occasionally fails a random test, they will report what value or what kind of value is an edge case to them, and you can add fixed testing for it. )"Math.PI"
might be an interesting edge case. :PYou need better failure messages, or test headers that include the tested value.
There are no test messages whatsoever. This makes it very difficult to figure out why a given test is failing. For this kata, most of them are just running the function with a value... but there's one near the end that isn't. So it just says "Expected: false, instead got: true", which gives me no idea of how to fix the problem.
I will try and make it a bit more specific. Thanks fore the feedback!
Thanks for the feedback I'll try and fix this "1e3", other than that did you find anything else thats a bug or are you just suggesting more test cases?
The instruction for this kata are vague. What is and isn't being considered a number?
Testing is severely lacking.
Amongst many, many others, the reference solution should be caught for not recognising the valid number string
"1e3"
.Loading more items...