Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
The kata is good, but there are too many unnecessary words in the description. This of course immerses in the context, but a little tightened. Anyway. working with a hierarchy is a common task, you need to master it.
This comment is hidden because it contains spoiler information about the solution
All the manager-related stuff in this kata is noise which adds absolutely nothing to the task, and it really should be removed. (If somebody decides to rework the kata this way, it'd be nice if the tables' and columns' names were changed to be more appropriate than they are now).
I'm opening this a
suggestion
but it's more of anissue
IMO.numeric
should be used for money calculations.Sample tests should have fixed data and proper test cases.
hard to approve if the test cases are a black box
I've amended - the chance of collision was around 2-in-a-million, but yes, it would have likely shown up at some point (and could've confused the poor dev that hit it!).
yes, that's always worth worrying about: considering the amount of users/tests launched, the problem will always show up, in the end.
Hi, I've added in some code to randomize the IDs of the employees, whilst there's a small chance of a collision, I don't know that it's worth worrying about.
I've changed employees_total to be an INT, totally agree that half an employee is no use to anyone. :)
Age is age-as-of-2016-04-01 as I understood it when completing the kata.
Have changed to INT.
It could be a very nice kata, shame it stuck at beta.
In description type of
manager
incompany
table isint
, but in reality it isdouble precision
. I think it should be changed toint
as it references toint
inemployee
table.Your dataset is not random except manager names anyway so it's trivial to hardcode the values.
i.e Needs much better random tests.
employees_total
should not be afloat
. It implies it's possible to have a fractional amount of employees.Also, why the age is from
2016-04-01
? This is not whatage
means in any common usage.Loading more items...