Ad
  • Default User Avatar
  • Default User Avatar

    @Mrityunjay Bhardwaj: It was me, who translated this kata to Java. As you can see below: There was a comment "Java-Translation kumited!"...

    There is no problem in the kata. (25 warriors did it in Java until this moment). And like dinglemause said it before: There is no biggertest for 1286608618.
    I tested it last minute, if such test would be succeed: Without problems with the solution.

    Have you you written the input value to the console for checking? Maybe your code changed a value in a wrong way?

  • Custom User Avatar

    Look a few comments down below: Steffen is the one who translated it and he has certainly a much better command of Java than me.

  • Default User Avatar

    @Mrityunjay Bhardwai.

    FYI - I have just moments ago successfully completed the Java version of this Kata. There are no problems at all.

    You said your code failed on a Java test called BiggerNumber with input of 1286608618.

    • But there is no such test in the Java JUnit. (For Java the test is called biggerTests)
    • And there is no such test input same as that either either

    So I don't know what you are looking at... but it not the current Java submission test cases

  • Default User Avatar

    @Mrityunjay Bhardwai, I know you think you are returning the correct result but it might be worth triple-checking that it's not you returning that -1. Sometimes the JUnit tests some of Katas are written wrong and the actual/expected values are reversed. It can lead to confusing situations like this.

    (Not saying that it the case here... but it might be)

  • Custom User Avatar

    I would post under the Java translator comment to ask for more direct support; sorry for the little help here.

  • Custom User Avatar

    Your tests seem correct, but do not get where you get the -1 expected result.

  • Custom User Avatar

    Thank you for your kind attention, the time spent on my katas and this kind feed; regrettably my Java is quite weak, so better luck writing under the post of the Java translator down below.

    Have a nice day :)

  • Custom User Avatar

    Thank you for your polite feed; I assume you are using C, so you have definitely better luck posting under the comment of the translator in that language down below.

    Cheers.

  • Default User Avatar

    Look, the pre-giving solution is:

    public class CountDig {
        
        public static int nbDig(int n, int d) {
            // your code
        }
    }
    

    There was no error in that!-)

  • Default User Avatar

    You are mistaking somewhere. Here are the "Example test cases" in Java:

    import static org.junit.Assert.*;
    
    import org.junit.Test;
    
    
    public class CountDigTest {
        private static void testing(int actual, int expected) {
            assertEquals(expected, actual);
        }
        @Test
        public void test() {
            System.out.println("Fixed Tests nbDig");
            testing(CountDig.nbDig(5750, 0), 4700);
            testing(CountDig.nbDig(11011, 2), 9481);
            testing(CountDig.nbDig(12224, 8), 7733);
            testing(CountDig.nbDig(11549, 1), 11905);       
        }
    }
    Look at the code of your function you gave above. It's you who called it "nb_dig".
    
  • Default User Avatar

    381 guys passed the Java kata so I am pretty sure there are no errors.