Ad
  • Custom User Avatar

    When fixing an issue on an approved, working translation, please remember to not fork the old translation, but use the Fork button on the kata page.

  • Custom User Avatar
  • Custom User Avatar

    Already approved by someone

  • Custom User Avatar
  • Custom User Avatar

    Thank you for the translation!

  • Custom User Avatar

    The author did this.

  • Custom User Avatar
  • Custom User Avatar

    That makes sense, my wtf was because the diff looked so weird.

    I made that using the JS highlighter specifically because there is no JS translation.

    I'm not about to attempt to review this beyond that though, I know nowhere near enough Lua.

  • Custom User Avatar

    This SHOULD NOT be approved until the description is changed to match the live version (since we have people randomly running around silently blind approving stuff these days).

  • Custom User Avatar

    Yup, I think it's sometimes a necessary trade-off between completeteness of output and its readability :( Merged, thanks!

  • Custom User Avatar

    I just don't know how to name each it_message. "Test" or sth else ? Idk

    This is the reason why I usually collapse such tests to a single it: because I do not have a good idea for titles either :) Naming all tests "Test" seems pointless. What I sometimes do is to build title from input up to some length, and truncate with ellipsis when the length is excedeed (for example: friends = { 'John', 'Tim', 'Anne', (5 more) }, and present full input with the failure message. Will it work well for this challenge? I do not know, would have to check and see. If you want to try, go ahead (one thing to remember: if you are going to propose changes to a language which is already approved, remember to use the "Fork" button in the kata, under the "TRAIN" button, and not in a translation).

  • Custom User Avatar

    Just know that my goal is not to plus-one anyone, but to improve coverage, and occasionally make something clearer if possible. You can always let me know when you do not agree with any of my changes.

    In case of this particular translation, I am not sure about the looooong titles of test sections. Usually, when inputs or outputs are expected to be loooong, I put all tests in a single it, loop over them, and present only the first failure. This way, I have only a small section titled "Random tests" or something, and not a long scroll of titles. But it's only my preference. We can leave tests here how they are, and see how they work for others.

  • Custom User Avatar

    Please see my fork for a proposal of some (hopefully) improvements. Let me know if there is somethign blatantly wrong with my LUA, or just fork and fix.

  • Custom User Avatar

    I would suggest not making the random names jAGgeD cAsE. They look bad when reported, and varied casing does not add much to this particular problem. Maybe making them regular Name Case would be enough?

  • Custom User Avatar

    I keep am icelandic keyboard for the extra letters and so I can test things like this. ð æ ö þ are these letters?

  • Loading more items...