Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Scrutinized tests
Added edge case of
0
and1
Added useful assertion messages
Modified module name
Increased random test count to 100
Very well pointed out!
This comment is hidden because it contains spoiler information about the solution
this solution does not cover the following scenario: [0,2,27,-60,57,99,-28,28,-15,7,-16,-63,32,82,-64,-57] expected: [0,2,-60,28]
Not a kata issue ~~ You should read the description and note everything now on a piece of paper to visualize it more easily.
After submitting only test that's not good is : 'should return the smallest value from 2 random arrays'.
Im not even sure what this supposed to test. Can somebody help?
Edge cases should be tested usually. Maybe it doesn't matter that much here, but I can imagine a manually implemented solution failing at
0
.How about more than 1 random test?
(
Translate
seems a weird name for a module too...)Modified random tests to run 20 times
Need more random tests :)
Thank you for spotting that! I just updated my test cases to have random tests.
Edit: Ok, should be working now.
Needs random test cases (see my hardcoded solution)
Marking question as resolved
Ha! Yeah, they're almost the same. Except yours is better described and tested ;) I looked through the approved katas to see if there were similar JS ones, but I hadn't looked through the betas.
Thanks, I can see it now. Take you time, I'll come back to this later :)
Loading more items...