Ad
  • Custom User Avatar

    Python testing framework is not used correctly. Assertions at top level are not a correct thing, assertions must be called inside of a function decorated with @it.

    You can see example kata or Python authoring guide for more info.

  • Custom User Avatar

    What is the result for d=.6?
    And d=.5999999999999999222844?
    And d=.6000000000000000333?

    P.S. They are all the same number (0.59999999999999997779553950749686919152736663818359375 or 5404319552844595/2**53)

  • Custom User Avatar
    • New test framework should be used
    • Multifactorial is no different from a regular one, so it's pretty much a duplicate
  • Custom User Avatar

    Maybe you should take a break from authoring katas. All (7) the katas you published before got retired for being low quality.

    If you want to improve your katas you can try solving more difficult katas and then check out their test setups.

    Also, on your previous katas people left helpful advice and links for writing higher quality katas.

  • Custom User Avatar

    Duplicate of numerous primes-related katas.

  • Default User Avatar
  • Custom User Avatar

    Hi,

    well... first published kata... At least you got the random tests (somehow... see below x) )

    • your random tests aren't random at all (because you made a typo in there so exist is actually never updated
    • your codes (tests and solutions) aren't really qualitative. Not a problem here, but well... -> your solution is the worst way to solve this task (talking about efficiency) / about the tests, you should use the new test framework, and you have antipatterns, in there or even useless parts (the import in the fixed test part, for example ; the predefinition of exist is an antipattern, and you'd surely avoided the error (first point) if you'd have defined it directly inside the loop)
    • about the task itself, we already have enough of this one (yours is actually a duplicate of several others. I won't even search for them, but trust me, there are. ;) )

    You can continue to play with the kata to improve your authoring skills, but I'd suggest to unpublish it (if you're fast enough, because the odds it gets retired in less than 20 minutes are pretty high).

    cheers

  • Custom User Avatar
    • Sample tests are broken
    • Converting between binary and decimal is a duplicate
  • Default User Avatar

    No random tests

  • Custom User Avatar

    Create a kata to hunt solution is not an acceptable play on CW