You need to sign in or sign up before continuing.×
Ad
  • Custom User Avatar

    PHP Translation to be evaluated, please review

  • Custom User Avatar

    Why is input an array and output a list? That's kind of inconsistent...

  • Custom User Avatar

    ok, that's far better. But you'll still have some modifications to do:

    • you need random tests ("real ones", meaning: if you do not know what it is or how to do it, look at the test suite of another kata you already did that contains some (you can play with the test by creating a fork of your solution, from the solutions page))
    • as soon as you create random test, you'll have something new to considere: should the warrior be allowed to mutate the input or not?
      1. if yes, you'll have to send a copy of the input list to the warrior, to avoid troubles using the same instance object for your internal solution and the one of the warrior
      2. if no, you'll have to state that in the description