• Missing return new Dictionary<char, int>(); in initial solution setup

• Missing fixed tests

• Code below does not give any useful information to solvers. User already got the previous message about missing keys in the dictionary they're outputting. You can however use the same failure message for random tests and place the previous mechanism in fixed test method.

if(!typePass)
  Assert.Fail();

• Sample tests could also do with the above message failure fallback mechanism.

• Random tests will not generate strings consisting of abcdef

• Assertion messages only display actual and expected results, but not the given input.

• Why public static class?

• Floating point comparison should be enforced with the usage of a tolerance value

• 5 random test is insufficient (should be 100)

• Missing useful assertion messages (it is a necessity for 8kyu kata)

Thank you very much!

Please see Translation authoring guidelines for ideas on creating a good quality translations. Please visit Codewars Discord and #help-translate channel if you need help with creating translations.

Fixed.

I apologize for any errors in the translation of this kata. I think they have been fixed. If this is not the case or more errors appear please let me know. Thanks for your understanding.

hotfix fork for Java

Not a suggestion + please do not post your solutions in the "Discourse" tab.

Hello. This I approved. I am not familiar with Java and it seemed to me that the translation is correct, but now I understand that I made a mistake! In the future, I will ask for help in code review. How can I fix the situation now?

Doh who even approved it :|
There is a bunch of bad java translations which popped up recently, I wonder if just rejecting them after a preliminary preview would not be a good idea.

Java sample tests:

src/test/java/SolutionTest.java:3: error: package traduccionCodewars does not exist
import traduccionCodewars.SecondOcurrence;

Java final tests:

Apr 13, 2023 8:43:29 AM org.junit.jupiter.engine.descriptor.JupiterTestDescriptor lambda$getTags$1
WARNING: Configuration error: invalid tag syntax in @Tag("Random Tests") declaration on [void SolutionTest.random_tests()]. Tag will be ignored.
Apr 13, 2023 8:43:29 AM org.junit.jupiter.engine.descriptor.JupiterTestDescriptor lambda$getTags$1
WARNING: Configuration error: invalid tag syntax in @Tag("Fixed Tests") declaration on [void SolutionTest.basic_test_cases()]. Tag will be ignored.

And the initial solution uses tabs instead of spaces.

you should add js for this kata

.