Ad
  • Custom User Avatar

    This is the most elegant solution. It should be on top.

  • Custom User Avatar

    Hi,

    In python:

    • the initial solution should be runable
    • the encryption dict should contain tuples as values, not lists
    • the encryption dict should be imported explicitely
    • in the tests (sample at least): the solution should imported explicitely
    • no fixed tests in the full test suite
    • 2 random tests aren't enough => build a loop and do like 50-100 of them
    • the tests shouldn't log anything to the console

    The last three points must be applied to all languages.

    General:

    • ...well... Sorry to say that, but the description asbolutely doesn't make any sense to me.
      • "the encryption dict is the card". But a card isn't a dict. => what is encoded and how?
      • "Pushing zone replaced with array "A" and "B"." -> wut? where? what zone A? what zone B?
      • "To read the symbol, you need to replace the corresponding letters and/or numbers with an empty string " " (aka hole)." -> WUT!? read where? from what?
      • "If the whole character row is in its place, it is a space in the string." -> WHERE!?
      • "pushing zone" -> not explained
      • "digit punching" -> not explained

    The description is describing stuff, but nothing is self explanatory. Especially when there are two methods involved (encryption+decryption) while it's never said when/where those are explained (and I bet they are mixed in the description)

    I finally understood (I believe) what I'm supposed to do, but in this case, I think one part of the description is wrong: If the whole character row is in its place, it is a space in the string. isn't that rather a column instead of a row?

    btw:

    • the content of the encryption dict (preloaded) isn't explained
    • when I look at the version in the sample tests, I have no clue what it means, since nothing has been explained.

    As you can see, the description needs a massive rethinking (but not necesseraly a lot of rewriting, I guess. Just a push here and there, with a proper structure might do)

    Cheers

  • Custom User Avatar

    I don't see a change. Did you re-publish?

  • Custom User Avatar
  • Custom User Avatar

    Python should use snake_case naming convention, not camelCase.

  • Custom User Avatar
  • Custom User Avatar
  • Custom User Avatar

    Preloaded encryption is typed as [String : [String]], when should be [Character : [Character]].

    Similar, all cards should be [[Character]] instead of [[String]].

  • Custom User Avatar

    No random tests

  • Custom User Avatar

    Duplicate of existing LCM and GCD kata.