Ad
  • Default User Avatar

    Using Assert.True in the ExampleTests on the collection of test cases makes the failure message unhelpful.

    Refactoring so each test case gives it's own failure message would be nice.

    I personally prefer TestCase or TestCaseSource for collections of tests.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    Nice kata. Reminds me to continue my series on kana (https://www.codewars.com/kata/kanakonverter-ii). Maybe later,...

  • Custom User Avatar

    I don't need to understand it now, my code was accepted, so this kata is finished;-)... Thanks for your reply and work!

  • Default User Avatar

    Yeah, some people use that. And the IME accepts that. I just wanted to make this less hard as it is my first kata.

  • Default User Avatar

    jyugyou -> 5

    Is "jyu" even a thing? I've only seen "ju".

  • Default User Avatar

    Yeah I was worried about whether people can understand what the description says. As I said, there won't be any tsu or chi or shi in there, so you don't need to replace it.

    I have added a RandomTest in the test cases. Hopefully you can understand what I mean by reading that. I don't know how can I word it better, without giving too much away.

  • Custom User Avatar

    For me your description (i read nothing else) was "hard" to understand in details and i don't know, if my solutions is completely correct or if some edge- cases are missing in your tests. I never heard about "kanas", so i "guessed some special cases" - perhaps you can see it in my code;-)...

  • Custom User Avatar

    ... deleted this message, codewars error (duplicate message)...
    By the way, welcome to codewars, just saw that this is your first kata, so generally well done:-)!