Is modifying the input really best practice?

1

5 yo , but anyway .

Vectors have a reserve member function .

So , even little ineficient can be removed ... with the right situation for reserve of course :)

i don t think so,as long as the code is very efficient(like this one) i don t think readability really matters,you can just put the code in a function and call it whenever you need it,so readability won t be a problem,unless you have to debug of course😂

bad practice for industry code. Code have to be simple to read and understand.

Considering the return type is unsigned int, you should use an unsigned int for the running sum, as it (normally) has a greater range of values than int. And signed integer overflow is undefined behavior. Unsigned integer overflow isn't - you could safely overflow and underflow and still arrive at the correct answer as long as it fits in unsigned int.

https://stackoverflow.com/a/10758845/12509349

The top answer does a very nice job of breaking down many different ways to print out the contents of a vector, which is very very similar to the problem in the Kata. While reading this, note that all the different techniques are supposed to do the same thing.

first and second are key terms in C++ which reference the first and second items in a pair. These are also used for the key and value of a map (dictionary).

genial

Can somebody explain this ???