Wth is the random test doing, for example can it be player1 = null , player2 = Rock;

and will it expect the code to return

"player 2 won" or what? I'm confused because it should be invalid.

I just did the same thing, instead of '-' i turned them into 2, It felt like cheating, but it works, my question is, is it good coding practice or not? bcuz it works super fine