Ad
  • Default User Avatar

    Ruby 2.5: main.rb:56: warning: constant ::Fixnum is deprecated.

  • Default User Avatar

    It's not specified what should be returned for invalid input.
    It's not specified what kind of invalid input can be there. Strings in Ruby look really unnecessary and unrelated to the task.

  • Default User Avatar

    Edge cases should always be tested.
    250 is specified as valid, but is considered invalid in JS.
    250 isn't tested in Ruby.

  • Custom User Avatar

    This is approvable without any Ruby completions. It would seem a good idea to have the Ruby translation tested a little before approving this.

    Please resolve this issue when the kata should be approvable again.

  • Default User Avatar

    Ruby :

    • no random tests
    • answer seems wrong

    For the first candle, the SA from 98 * 196 is 75429 which is higher than a 123 x 123 candle (71293)?

  • Custom User Avatar

    There are no random tests.

    Also, this goes without saying, but once you start making random tests you'll realize that this kata is a bad idea (or free text parsing in general).