it("given (4, 19)", function() {
  assert.deepEqual(ferrisWheelCabins(3, 7), -1);
});

very wonderfull drawing, I felt positive making this kata, tnx

Impressive first time kata Tiarama - fun too!

I changed the exceptional case return value to -1

Thanks for the comments, I'm learning a lot

IMHO throwing an error is better than returning some arbitrary value.

-1 or throwing error is better, null is worse (because, it is still multiple output types, and such code removes type hints from IDE, if you're using any).

Returning 0 in the exceptional case is a bad idea - that value can also result from an inexceptional case ( (0,0) ).

-1 would be a better idea. Or throwing an Error. Or returning null ( an empty value ), though not everyone will agree with that.

I've implemented all of this now - This is my first kata so sorry for the messiness and thanks for the feedback!

yes and no:

• there are random tests, now, but you need to have fixed tests too, before the random ones ;) => add the sample tests before the random ones
• it would be better to have one single generation function with a parameter, considering what you did so far for the random tests
• usually, the number of random tests is around 100.

I think I've solved it, thanks for the feedback!

• No random tests
• Returning multiple types is bad practice

Note that your solution is wrong. The tests are bad.

Ahh okay, ace thank you!

Test.assertEquals(XO('xxxoo'),false); You're confusing the logs, they appear above the test result.

My code is passing all the attempts except for the 4th one down.
console.log reveals str to be 'xxxoo', but it is expecting the result to be true.
Am I missing something?