Ad
  • Custom User Avatar

    Hi,
    Sorry it wasn't working as I messed up the order of arguments when writting the initail solution. I was just making this as a simple thing more for myself to work out how to validate pandas dataframes and how the test framework works. I can understand having an assertion message so have added one in however I was intending to use test.assert_equals but that doesnt seem to work for pandas dataframes.
    Thanks

  • Custom User Avatar

    Thanks. That was my mistake when writting the initial solution. It should be fixed now.

  • Custom User Avatar

    cols and data are swapped in the arguments

  • Custom User Avatar

    Hi,

    Looks like nothing is working properly, no?

    Also:

    • the test framework isn't used properly
    • don't ever use test.expect, unless you provide a useful assertion message (which is exactly why I have no idea if the kata is working properly or not...)
    • Errr... what's the actual point of such a task? Imo, you should unpublish it.

    Cheers

  • Default User Avatar
    input:
    A [50.86891010043061, 59.211612840676366, 14.095573965283215, 53.92947021245732]
    B [92.83868642109032, 92.74100718351963, 66.45347831348518, 7.343025635242084]
    
    output:
    'The winner is B after 1 attacks!' should equal 'The winner is A after 0 attacks!'
    

    I think there's an error in your solution.

  • Custom User Avatar

    Random tests should have the correct describe/it structure.

  • Custom User Avatar

    Thanks for the feedback. This is my first kata so im unsure about some of these things. I believe I have now added some random tests.

  • Default User Avatar

    Reference solution is wrong.

  • Default User Avatar

    With float values the result depends on the order of operations.

  • Custom User Avatar

    The input should be (tuple, tuple) instead of (str, str, dict).

  • Custom User Avatar

    No fixed tests where the second fighter is the winner.

  • Custom User Avatar

    No random tests.