Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
+1 for visibility
Good catch. Should be fixed now. Thanks for your feedback.
Good point!
Will change it immediately!
Thanks.
No probs.
Your
Line.new()
can return an object. And the pool can just be some variable somewhere that is referenced byLine.new()
. Does that help?Thank you very much for the feedback. This is my first kata and I appreciate the advice. I have cleared up everything you outlined and republished.
Note: I keep getting a time out error when updating this. I'll get the changes pushed out once I can get a connection.
You're welcome!
I have added some more tests to detect the use of
intToChurch
function. In any case, I think this is not really necesary because if you useintToChurch
, you should get a stack overflow error.That one's actually already covered. Thanks though!
In the description, I added "A label may be declared either before or after a command that refers to it."
As a test case, I added a no-exception edge case:
This includes a valid sequence of code containing a substring that could be interpreted as a label, but should be attributed to other commands.
Reviewing your code again, it seems I should do the same for the clean termination test case. (now added)
Can't really think of a concise way to describe that off the top of my head, but when I do, I'll add it to the description. The way you implemented forward labels though, I'm not sure it should work 100% of the time, so I might add a couple more test cases if I can find a way to break your solution.
The easy way is just to do two passes on parsing the code, doing nothing but collecting labels on the first pass and everything else on the second pass. The "lazy" way, where you don't collect the labels ahead of time, is definitely harder to implement.
Glad you liked it - and you are correct with the wiki link.
You're welcome!
This comment is hidden because it contains spoiler information about the solution