there will always be only one or zero occurances of '#' so there will only ever be two strings

I like this. One minor tweak here would be to start Range at 1 instead of 0 since 0 will never contribute to a sum, but that just saves you one iteration.

Pro tip: don't waste your energy trying to up the quality of codewars posts

Bad practice because:

1. It finds all occurrences of '#' in string
2. Gets all possible substrings
3. Takes just one of them.

Thanks :-)

nice idea :)

wtf dude...

this site might be inspirational, but it's rarely a good idea to blindly copy code from 99% of the solutions.

Regardless of it being marked as "best practice" or whatnot.

Ok I tested it against 7 other solutions, once I reached string lengths around 30,000 there was a sudden loss of competitiveness from a midling 4th place to last place and three times slower than the next closest, at 300,000 it has reached about 30x worse

I get that it's a coveted oneliner but someone at least ought to point it out before you start cutting up Billion character strings. it's kind of irrelevant at the current scale also it seems like one of the faster one line solutions

https://xkcd.com/1691/

Yes, it seems is shorter code but the operation every cycle could make it slowest.