Ad
  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    I think the 'in map' if/else conditional at the bottom of your move function will fail to catch the case where, e.g. you're at position 10 and try to move left. That should probably be checked for in the suite of submission tests, and perhaps I'm missing something obvious.

  • Default User Avatar

    I thoroughly enjoyed this Kata, but it could definitely use some clarity improvements.

    The Kata description should describe the Ball(object) and Ghost(object) classes, their attributes, and say that they are already implemented. I implemented my own Ball class and had started implementing my own Ghost class before I read the discussion and saw you had implemented them.

    Mention and link to your other Kata regarding creation of the Ball class. Perhaps there's a Ghost class Kata as well (if not, I'd love to see you make it!).

    As others have mentioned, inconsistent naming (and in particular the omission from the description of the Ghost.color attribute name) is a bit confusing for working up a solution.

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    Ah, okay. That's more or less what I suspected, but I couldn't view the test cases prior to submission. Thanks!

    Do you know if that test exceeds the max recursion depth of default Python 2.7, or if it just times out due to codewars' solution time limit?

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Default User Avatar

    In general I would not view this solution as best practices because the built-in function "type" is being masked. Am I wrong to think so in this context?

  • Default User Avatar

    I imagine this solution could run into errors missing right triangles due to float conversion giving not exactly 90.0 degrees output when floats are represented and manipulated in binary. Does Python not have the same float comparison warnings as C++?

  • Default User Avatar

    As a beginner, it was unclear to me based on the description that I needed to type/sign check the input arguments. If that requirement has been removed, it seems that the "best practices" and "most clever" solutions after submission do not reflect the current state of the kata. Is there a method to sort solutions by kata revision history?