It is possible for the kata description to be updated on the kata itself, after you have updated the description here. When this happens, if there are merge conflicts an additional fork will need to be made to merge the differences together.
actually i don't know about when and why merge conflicts occur, so i do not really know
where to look for what kind of error and what i need to do to reproduce the merge conflict.
google gave me https://github.com/Codewars/codewars.com/issues/1949
so i forked the translation
The tests in the java-version does not use assertEquals correctly. When checking the number of groups, it does
assertEquals("found too many or too few groups.", m.groupCount(), 3);
but Syntax of assertEquals is
assertEquals (<text>,<expected>, <actual>)
so it needs to be
assertEquals("found too many or too few groups.",3, m.groupCount());
brackets were kind of stuck in my head because i did the Julia-Solution before translating.
I changed them to braces which is of course much more java-esque.
-good hint with the internal solution, didn't think about people probing for it. I made it private
In my opinion, the actual description is clear and logical and I have the impression it is what was intended with the task.
Finding a clear and logical explanation for (won,lost) = (0..2,0..1) seems a lot more fuzzy to me, so to me it seems to be
more logical to adjust the test data to the actual description/intention.
As ((1,0),(0,1)) is just a subset of ( rand(0..2),rand(0..1) ), which is the actual test setup, I would expect all valid solutions to still be
valid. But that is of course up to be discussed among people more able and saner than me....
tests changed,thanks
Corrected, thanks!
Thanks for the suggestion, I changed the code of the sample tests and tests accordingly
Thanks, that was helpful.
Help section says
so the fork should do the trick
actually i don't know about when and why merge conflicts occur, so i do not really know
where to look for what kind of error and what i need to do to reproduce the merge conflict.
google gave me
https://github.com/Codewars/codewars.com/issues/1949
so i forked the translation
The tests in the java-version does not use assertEquals correctly. When checking the number of groups, it does
assertEquals("found too many or too few groups.", m.groupCount(), 3);
but Syntax of assertEquals is
assertEquals (<text>,<expected>, <actual>)
so it needs to be
assertEquals("found too many or too few groups.",3, m.groupCount());
Thanks for reviewing.
I changed them to braces which is of course much more java-esque.
-good hint with the internal solution, didn't think about people probing for it. I made it private
Great Kata. Everybody should be able to try this, so I kumited a
Java translation.
Please review and approve.
Java translation kumited, please review and approve.
Java translation kumited. Please review and approve.
The signature has been fixed some time ago. I added some sample test cases and random tests as well.
I published a java translation of this,please review an approve.
Forked and corrected, the "merge conflict" does no longer show up. I don't have experience with that kind of errors, i hope i did it the right way
In my opinion, the actual description is clear and logical and I have the impression it is what was intended with the task.
Finding a clear and logical explanation for (won,lost) = (0..2,0..1) seems a lot more fuzzy to me, so to me it seems to be
more logical to adjust the test data to the actual description/intention.
As ((1,0),(0,1)) is just a subset of ( rand(0..2),rand(0..1) ), which is the actual test setup, I would expect all valid solutions to still be
valid. But that is of course up to be discussed among people more able and saner than me....
Thanks !
To produce something with only tupels of (won,lost) = (1,0) | (0,1) something along the lines of
should do the trick
Loading more items...