Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
duplicate of this issue
Approved some time ago
'alr approved some time ago'
I think for avoiding misundestanding you should clarify this moments, thank you :)
Use spoiler flag next time, please.
This comment is hidden because it contains spoiler information about the solution
Example tests were missing
assert
definition, therefore usingNode.assert
, therefore showing even a passed test with a red border. I fixed that.I also set the default
Node
version to10.x
, because I could. Why wouldn't you use the most recent supported version? You were already usingchai.assert
anyway?JS convention is to use camelCase, not snake_case. People are going to hate on that. It is very highly recommended to follow naming conventions on here.
Some explicit remark somewhere to return
[x,y]
and not the usual[y,x]
would be nice. ( I know, I know, maths use(x,y)
. But JavaScript uses[y][x]
and it's what we're used to. )Accidentally deleted it when changing the actual test cases. Thanks for catching that.
Great, approved! :-)
Awesome! Would have merged it, but it says the latest changes from the record must be merged first?
There's no such thing as "trigit". Even
ABCDEF
in hexadecimal are called digits.I will tighten up the description. It currently expects this to count as zero time available.
Fixed :)
I might add random tests in the future.
Yes,you are right.
I'm going to add that in description.
Thank you!
Removed random tests for now, I didn't write them so don't know how to resolve them