Ad
  • Custom User Avatar

    Floating point comparison should be enabled in Ruby

  • Custom User Avatar

    Description should be language-agnostic

  • Custom User Avatar

    Tests are broken in js with nested arrays in many cases, it seems like tests modify randomly the arguments in a bad way: for example, with an original array '[ 2, 3, [ 2, 10 ] ]', tests return "Wrong value for [2,3] - Expected: 2, instead got: 12".

  • Custom User Avatar

    Random tests:

    Wrong value for [6,[3,5,[2,6],[[]],[]],[[8,[]],[],3,4],[1,[4,6,[8],9],1,4,2],[1,[[]],5,[],[[3,[2,[[]]],3],[],2,[3,10,5]]],3] - Expected: 9004099622918398000, instead got: 9004099622918401000

    There are still arrays with result outside the 53-bit safe integer range.

  • Custom User Avatar

    Test cases should be provided.

  • Default User Avatar

    I think you need to include more/better test cases. Like randomizing both the Arrays and the number of arrays.

    I also think you should put some example test cases. I can imagine for someone who's not dealt with it before that a variable number of arguments might not be obvious.