Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
Usually it would not be the best practice because of variable leakage, but this kata is made for this xD.
Fails for
deepCompare(null, {})
, same reason as @bbroeksema points out.typeof null === 'object'
. I was trying to parse the way you return on===
and on!== 'object'
to see if there was some clever avoidance, but it's not so.I haven't found a way to avoid doing a null check at the top and a
===
value compare at the bottom, separately.There is (unless it was just added recently), but it had
null
aso1
andundefined
aso2
, so the third line of your code (typeof o2 !== 'object'
) returnedfalse
.Certainly true.
Then there should be a test for that, right? :-)
This doesn't work for:
typeoff null returns 'object', so it will pass the third line, next Object.keys(null) will throw an error.