Ad
  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar
    • Expected and actual are swapped.
    • Results list should be sorted in ascending order according to description.
    • Please add assertion messages showing the inputs on failure.
    • Missing random tests.
    • Please also add the other sample and fixed tests from the other languages.

    I will reject this translation. You can fix the above remarks by forking this translation.

  • Custom User Avatar
    • Results list should be sorted in ascending order according to description.
    • Please add assertion messages "\nYour result (left) did not match the expected output (right)" which also show the inputs on failure.
    • Missing random tests.
    • Please also add the other sample and fixed tests from the other languages.

    I will reject this translation. You can fix the above remarks by forking this translation.

  • Custom User Avatar
    • Results list should be sorted in ascending order according to description.
    • Please add assertion messages showing the inputs on failure and proper names for Describe and It blocks-
    • Missing random tests.
    • Please also add the other sample and fixed tests from the other languages.

    I will reject this translation. You can fix the above remarks by forking this translation.

  • Custom User Avatar
    • Expected and actual are swapped.
    • Results list should be sorted in ascending order according to description.
    • Please add assertion messages showing the inputs on failure.
    • Missing random tests.
    • Please also add the other sample and fixed tests from the other languages.

    I will reject this translation. You can fix the above remarks by forking this translation.

  • Default User Avatar

    Changes:

    • Used C++11's <random> instead of std::rand.
    • Simplified the random testing strategy.
    • Added ExtraMessages.
    • Tests now adhere to the Kata's assumptions.
    • Fixed the issues outlined here.
  • Custom User Avatar

    yeah, I know ... But I dont have to ¯_(ツ)_/¯

  • Default User Avatar

    This is python, you can solve it in one line

  • Custom User Avatar
    • Removes confusing tests & solution setup
    • use std::string + array instead of char* and vector
  • Custom User Avatar

    Hey,

    sorry for not providing more information beforehand

    The motive was just to make it more C++-Idiomatic and thereby simplifiying how tests can be written and the solution itself.

  • Custom User Avatar

    Hi,

    May we know what is an actual motivation behind this fork? Is it only to make the function interface more idiomatic, or does it also fix any actual issue reported by someone?