Ad
  • Default User Avatar

    what about "\nbug" ? is it out of the scope of this kata ? some solutions would not detect it

  • Custom User Avatar

    Python: missing it block for random tests

  • Default User Avatar

    JS : my solution would fail for:

    • empty array
    • array with duplicate paths like ['/web/images/', '/web/images/']

    they should either be explicitely out of specs, or tested for

  • Custom User Avatar

    This issue is still relevant in JavaScript.

  • Custom User Avatar

    Please throw an exception "Selector parts should be arranged in the following order: element, id, class, attribute, pseudo-class, pseudo-element" if selector parts arranged in an invalid order.

    The tests for this are not exhaustive.

  • Custom User Avatar

    The combine operator does not make sense in this kata; in fact it doesn't even belong to the builder because combine does not keep the capability of the builder invariant: you can't use any other operators after combine is used (trying to add a class to something like p#introduction ~ img[href$=".png"] makes no sense at all (unless you're doing SASS and allows nested CSS, but that's not CSS)).

  • Default User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    Nice one.
    I suggest to add a visual description.

    First example :

    1 || πŸŒ• || πŸŒ‘ πŸŒ‘ || 0

    2 || πŸŒ• || πŸŒ• πŸŒ‘ || 0

    1 || πŸŒ• || πŸŒ• πŸŒ— || 0

    1 || πŸŒ• || πŸŒ• πŸŒ• || 0

    Denied : 0

    Second example :

    1 || πŸŒ• || πŸŒ‘ || 0

    1 || πŸŒ• || πŸŒ— || 0

    2 || πŸŒ• || πŸŒ— || 2

    1 || πŸŒ• || πŸŒ• || 0

    Denied : 2

  • Custom User Avatar

    That freshly baked Python translation uses pathes as the preloaded function parameter. Should be paths :)

  • Custom User Avatar
  • Custom User Avatar

    There's already a kata about implementing the builder pattern, which also has less repetitive work to do, no annoying input validation, and no bad design decisions (using the same instance as the base for all builds, mixing static and instance methods).

  • Custom User Avatar

    Please throw an exception

    None of these cases are mentioned in the description.

  • Custom User Avatar

    the tests are literally bullshit: I pass every fixed tests but not any random tests....

    • needs more proper fixed tests
    • need a batch of small random tests.
  • Custom User Avatar

    add several random tests and i;ll approve the kata

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Loading more items...