Regex is adding unnecessary overhead here

i knew i could do this in java but i have never tried catching an error in python good one

Powerful code, nice

Please use spoiler flag next time.

and they're free to change it. it's not like that would be surprising to them.

that has been the name of that arg for 9 years.

I think it's a valid nitpick. and if it was a name of my choice, introduced by this set of changes, then I'd look for a different name to use. I prefer to keep what's already there in this case.

It can cause issues if a user is utilizing the string module in some way, as shown in the code below:

import string
class Cipher(object):
    def __init__(self, map1, map2):
      pass
    
    def encode(self, string):
        x = string.ascii_lowercase

the sample tests did have one instance of describe that should have been an it, yes. I changed that one.

the tests themselves don't miss it. you may need ctrl f to spot it.

string isn't a name defined by the builtins module. there is a module named string in the standard library, I see nothing wrong about that however.

• missing it blocks
• probably should not use string as variable names (inbuilt imports)

Lol I'm the same way. I enjoy seeing these one line solutions, though, because it helps me learn how to write more efficient code

i dont get it

gj)