Ad
  • Default User Avatar

    B116013, check out mgol's answer. I think there is no issue. Please open a new question if you still have one.

  • Custom User Avatar

    Check out for number 5: If a block to be encoded contains all nulls, then that block is encoded as a simple z (ASCII 122) rather than the fully-encoded value of !!!!!

    You have to check if the input is zero padded

  • Default User Avatar

    Seems to work perfectly fine, now (I just checked with the sample tests)

    :)

    EDIT: if ggmoy did the translations of the 2 remaining verison (if I remember well, I have already corrected the 2kyu version), you should take a look at those. He certainly did the same mistake in the other versions.

  • Custom User Avatar

    @B116013 I think I fixed the Java translation, feel free to ping me if you find any other Issues :)

    @Blind4Basics Thanks for the offer but I've published and approved a fork to @ggmoy's Java translation already. It would be great if you could test the Java translation for me though, just to confirm that there are no other Issues :D

  • Default User Avatar

    I'm no one... ;-p (most of the time, at least). You take care of this ?

  • Custom User Avatar

    Thanks for stating the language in which you are encountering this Issue.

    expected solution is different from the answer in the test case

    By that, I suppose you mean "the actual and expected values are swapped in the assertions"? I've just checked the Java translation for this Kata and again, the actual and expected are in the wrong order *sigh*. Why does no one ever translate a Kata into Java correctly?

    In response to this Issue Report, I will be fixing the Java translation shortly. Thanks for the report :D

  • Custom User Avatar

    @Blind4Basics,

    Many thanks for the fix, your fork of @ggmoy's Java Translation has been reviewed and approved :D

    Cheers,
    donaldsebleung

    P.S. B4B, a little bit off topic, but I would like to confirm once more that the order of arguments in a typical JUnit assertion is [message, ]expected, actual? I will make sure to keep that in mind when reviewing future Java translations :)

  • Default User Avatar

    Hi,

    I checked it and the actual and expected are effectively swapped in Java. I forked the translation to correct it. ;-)

    Cheers,

    B4B

  • Custom User Avatar

    Thanks for taking the time to tell me which language you are referring to. Of course it's Java (again, sigh) - a few other users have commented that Java is a special snowflake here on Codewars in terms of writing and translating Kata.

    If you are still stuck on this Kata and would like help regarding why the assertions are failing, please copy and paste the relevant test output here (including key details such as actual and expected values, and the arguments passed into your interpreter) so I may investigate this "Issue" and determine whether it is a problem of this Kata or a problem of your solution.

    Additionally, you could also copy and paste your current solution here and mark it as a spoiler, and I'll see if I can spot the problem (I don't really know Java though). Hope this helps :)

  • Custom User Avatar

    Resolving this Issue because:

    1. There is insufficient evidence that this "Issue" is indeed caused by a bug in this Kata and therefore needs fixing
    2. Insufficient details were provided on this Issue, e.g. what language is this Issue occuring in?

    A few things to note before you file an "Issue" on a Kata:

    1. Confirm that the errors/failing tests you are receiving are indeed due to bugs in the Kata itself and not your own solution
    2. Please specify which language you are encountering this Issue in. A Kata may be very well written in one language but may be broken in another.
    3. Provide as much detail on the Issue as possible so it is more likely that the Kata author knows what the problem is and fix it. In your case, you could provide details on the input passed into your interpreter, what your interpreter returns and the expected output strings where you are failing the tests.
  • Default User Avatar

    I don't understand. Please could you give your language and be more precise.