And here I am using recursion to solve this :)

I don't think this is the best practices:)

key_copy = key is not how you copy an array. The correct way is key_copy = key[:].

IMO you should drop this "generate a random string" idea, and rework it from scratch. Your "randomness tests" are bad, and it will be hard to write good ones. At this rate it would be a lot easier if you generated a random string yourself, passed it to the user, and asked to hide the encrypted message inside. At least, that's what I think.

Yes I know I'm not doing it the right way, but I just don't know which is the right way. If you have any suggestion I would really appreciated.

And yes, i see now that I didn't solve B4B's issue, I think I solved it now though.

Thanks!

Your way of closing these holes is fundamentally wrong.

note that you need to send copies of the leys arrays to the user, if you use the same instance array several times

A point from B4B's issue which you marked as resolved despite actually fixing...

https://www.codewars.com/kata/reviews/5c5364a068b5b70001e3cb4d/groups/5c5b0bccb743620001c9e1be

I improved the randomness checks. Hope thats good enough.

I guess I'll never play with random again :D

I added some extra checks that hope will solve this and other issues

Indeed! This Your Kata Is Just Nice! (*)(*)(*)(*)(*)

Yes, that is usual to merge translations! Try to avoid forking if there is such an option to choose...
Or unless you try to resolve merge conflicts or improve some translation...

Got it, thank you both, I am relatively new to python so still figuring out a lot of things!

import random is still in the initial solution of python. It should be removed from there and moved to the test suite. Either put import random at the top of the test suite and use random.randint and random.choice; or put from random import randint, choice and use simply randint and choice; currently you're mixing the two methods and rely on the user's solution to import random.

Hi uniapi, this is my first kata ever, and I'm still figuing out how things are done. I chose to merge your translation with my kata, is that ok or should I have chosen to fork it? If you want me to fork (and I am still able to do it) just let me know.

Thank you for your contribution! You are a very brave man working with assembler! :D

https://www.codewars.com/kata/reviews/5c5364a068b5b70001e3cb4d/groups/5c5871d19fc8660001f35a52

I was referring to the fact that your tests use random.choice without importing random.