Ad
  • Custom User Avatar

    Honestly I have no idea why satisfaction rating for this kata is so low. Personally I liked it a lot, interesting and really good for the beginners.

  • Custom User Avatar

    Resolved with the approval of the latest fork.

  • Custom User Avatar

    Resolved with the approval of the latest fork.

  • Custom User Avatar

    Resolved!

  • Custom User Avatar

    I did find a bug in the error reporting code which may have confused you; sorry if so!

    However, the actual pass/fail results of the random tests are correct and your solution is not. It was just the formatting of the error messages which was wrong; please try the following test case and observe that your function does not behave as it should:

    describe("Another test", () => {
      const hole = [
          { val: '4', suit: 'Hearts' },
          { val: '6', suit: 'Hearts' }
      ];
      const flop = [
          { val: '6', suit: 'Spades' },
          { val: '9', suit: 'Spades' },
          { val: '6', suit: 'Clubs' },
      ];
    
      it('is a set', () => {
        assert.strictEqual(isSet(hole, flop), true);
      });
    });
    

    Issue resolved.

  • Custom User Avatar

    The random tests results are just as the tests... Random.
    This is a waste of time for any Kyu level player.

  • Custom User Avatar

    I love card katas, and all the changes look extremely good and reasonable to me

    These three classifications may overlap; for example, a hand with four-of-a-kind in it has a pair and a set, but not two pairs.

    This nuance is especially something this kata description had to have

    Approved

  • Custom User Avatar

    Substantial fork created, verging on a full rewrite; looking for review/approval.

    https://www.codewars.com/kumite/6549b86f234c0d260c44be3f

    Highlights:

    • Node version => 18.x
    • Test harness => Chai
    • Shiny new description (better language, more accurate terminology, hopefully clearer and easier to read)
    • Un-f***ed the random tests which seem to have resisted fixing for ~6 years.

    I believe this addresses all open issues.

  • Custom User Avatar

    Still broken.

    [ { val: '10', suit: 'Spades' }, { val: 'Ace', suit: 'Diamonds' } ] 
    [ { val: '10', suit: 'Diamonds' }, { val: '10', suit: 'Hearts' }, { val: 'Jack', suit: 'Clubs' } ]
    
    isSet(hand, flop) // => Expected: 'false', instead got: 'true'
    
  • Custom User Avatar

    Ok, will check

  • Custom User Avatar

    It is not resolved, I've tried it just now.

    Failed at isSet:
    [ '8_Spades', '7_Clubs', '7_Spades', '7_Hearts', '10_Spades' ]
    Expected: 'false', instead got: 'true'

  • Custom User Avatar
  • Custom User Avatar

    Resolved

  • Custom User Avatar

    I find it very strange that you can have two identical cards in a deck of cards. Also, the random tests are not very good, they expect the wrong answer sometimes. I clicked on attempt a few times before it accepted my solution.

  • Custom User Avatar

    For isSet:

    [ { val: '5', suit: 'Hearts' },
    { val: '10', suit: 'Diamonds' } ] [ { val: '3', suit: 'Hearts' },
    { val: '3', suit: 'Hearts' },
    { val: '3', suit: 'Clubs' } ]

    Expected: 'true', instead got: 'false'

    Why? Should be false.

  • Loading more items...