Ad
  • Custom User Avatar

    this is the best solution

  • Custom User Avatar

    I like this one... it really takes into consideration big arrays, as the description said

  • Custom User Avatar
  • Custom User Avatar

    Just modularized logic for readability. Your solution is the best.

  • Custom User Avatar

    +1 nice way of finding out the polarity
    +1 returns when found

  • Custom User Avatar

    It's not so much what I want; I just wanted to point out that you can pass all the tests with code that doesn't completely do the job. If you look at my solution, you'll see that I don't consider the value of $shift: the code assumes the shift is always 1, but the tests all pass. After passing all tests and submitting, I realized that I'd missed a key part of the requirements.

    I'm being a bit nit-picky. But you might want to add a test that uses a $shift >1, and test only the encode function (in other words, don't round-trip it).

  • Custom User Avatar

    For the time being not many guys passed the PHP kata but the tests are exactly the same in all languages and as you can see at the top of the page 340 guys the kata so I am sure that there are no errors in the tests.

    Edit: maybe I don't understand very well what you want, sorry:-(

  • Custom User Avatar

    Actually I loved this kata except for one issue I think I've found with the final 'attempt' testing. My original code did not consider the rotation; it always shifted the characters by one. Oddly, it still passed the 'attempt' testing. But when I added the rotation to the shift, the W.B.Yeats quote failed, because the shift took many characters out of bounds. My guess is that the Yeats quote runs the full cycle without testing the encoded array of strings, and that there is no test for encoding a non-one letter shift (otherwise my attempt would have failed). Does that make sense? Note: I'm working on the PHP version.

  • Custom User Avatar

    It would be helpful to see the Node constructor, either in the instructions or the code itself. I've done all the "prerequisites", but I had to view a previously solved kata to figure out that I was passing the parameters in the wrong order.

  • Custom User Avatar

    Hey bobtrigg,

    the issue should be resolved. I misplaced the given class in the attempt to translate the kata to PHP. SleepingCode fixed this issue, so you should be able to train this kata now.
    If any other problems should occur, please don't hesitate to inform us again :-)

  • Custom User Avatar

    Hi, the translator should have already fixed the problem now.
    I'm marking the issue as resolved, tell me if there are any problems.

  • Custom User Avatar

    Hi,
    sorry for the incovenience.
    We are fixing the problem (see above for the discourse with 'kolossa').

    An advice: mark the issues you encounter with the 'issue' flag, so it is easier for those who should fix that to spot your message.

  • Custom User Avatar

    Hi,
    I could infer that you are talking about the PHP version of the kata, is it correct?
    I'm reforwarding the issue to the translator.

  • Custom User Avatar

    I got the same Class 'PolynomialSimplifier' not found error. Could you please let me know how to get this resolved? It's a killer kata and I'd like to see some other solutions!

  • Custom User Avatar

    This was a pretty easy kata in PHP, and I found the warning about large numbers to be misleading since my code was about 7kyu complexity and refused to fail. Also, it would have helped to explicitly state in the description that n represents a fib sequence (the reference is indirect). Otherwise a satisfying kata.