RISC-V Translation

I suppose a slightly more detailed explanation is in order. Neither of the two changes the resulting binary at all; it's purely an aesthetic concern.

For the and/andi one, yes the assembler is being permissive here.

For the li one...

The compressed instruction extension has 16-bit versions of c.mv and c.li. However, the source of c.mv cannot be x0/zero. The assembler here helpfully transforms mv a0, 0 into addi a0, zero, 0 then into c.li a0, 0, but I'd want li here to remind us that this is closer to how the instruction gets encoded.

I was not careful enough to distinguish between and and andi, but it seems that the RISC-V assembler was generous enough to fix them for me :)

I thought mv is pseudoinstruction that used widely...

Approved

Nothing really I'd say is wrong here, but some nitpicks:

• and t0, a0, 3 and and t0, t0, 3: and -> andi
• mv a0, zero -> li a0, 0 (twice)

Fork with some improvements: https://www.codewars.com/kumite/654780f41498050b75cec0f4?sel=654780f41498050b75cec0f4

Improves feedback of failed random tests.

RISC-V translation

This is my first translate submission. Please review carefully. Thanks.

Thanks, very nice solution. I struggled with this one with overflow problems and finally got it working but with not nearly as elegant a solution as this.

Very clever!

added

Suggestion :: Add "tetrafluoromethane" = {'C': 1, 'F': 4} as fixed test.
This test makes sure that non-exist element should be removed from result.

I made a quick fix to remove those 0 values. The tests are still generating the invalid inputs but at least the output is well formed now. I'll close this issue because it's basically the very same as the one below now.

Cheers

I'll have to rebuild those tests... yeah, ethenyne isn't possible. It shuldn't be generated at all by the tests.

During random test, I got following error ::

eth-1-enyne: {'C': 2} should equal {'H': 0, 'C': 2}
ethenyne: {'C': 2} should equal {'H': 0, 'C': 2}

I'm not going to argue whether we can call "C2" as "ethenyne".
However, it is very weird that removing non-existent element from result causes errors.

If we should output "ethenyne" as {'H': 0, 'C': 2}, why not {'H': 0, 'C': 2, 'O': 0, 'N': 0, 'Cl': 0, 'F': 0, ......}?