Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
You do not need the 'return' for Ruby in this case, though. The == operator will always give a return value of true or false.
Oh okay. My bad, I didn't read the instructions well enough.
Yes it should. Because the Kata specifically asks that the result should be sorted.
This comment is hidden because it contains spoiler information about the solution
I printed the 'char_to_morse_dict' and noticed there is no difference between the values of uppercase and lowercase keys.
It seems kind of unnecessary since it is simple to call lower() or upper() on 'string'.
I think the name of the dict should be shortened to 'CODE_TO_MORSE'.
It seems repetitive and obvious to include '_dict' at the end.
The reason I have capitalized the dict's name is because of PEP8.
"Constants are usually defined on a module level and written in all capital letters with underscores separating words. Examples include MAX_OVERFLOW and TOTAL."
Based on my suggestions:
It's called: CHAR_TO_MORSE
and it's written within the initial solution -->
Javascript: //CHAR_TO_MORSE preloaded to convert characters into Morse code.
Ruby: #$CHAR_TO_MORSE preloaded to convert characters into Morse code
Pyhton: #CHAR_TO_MORSE preloaded to convert characters into Morse code
Can't figure out what the dictionary name is called.
Doesn't specify that you must return only the boolean, makes it seem like you need to return a string saying why it can't be divided by x or y
You should provide some test cases.
In the C# one it returns Boolean, which is not a default type. It should return bool.
Sorry, that's not quite what we were expecting! - Expected:
instead got:
I think the JavaScript one needs some default test cases.