solved

Merged the fix for swapped actual and expected.

Fixed.

Corrected Here

Corrected for PHP for swapped values, more tests will do later Here

Merged.

LGTM, approved

approved

Fixed.

yes, I was referring to the Solution tab. when you upgrade something, you usually want to leave that tab untouched, because it serves as a hint that no breaking change was made and previous solutions will still pass. of course there are exceptions if either:

• the solution was wrong
• the function's prototype was changed by the fork
• the solution was using deprecated features (either language-wise or Codewars-wise) and needs to be changed for forward compatibility

If you're referring to the Solution tab, no real reason. I just copied and pasted from my own solution. If that's not allowed, please let me know. For the refsol, I just tweaked it to use one loop instead of two and gave the variables better names. It's basically the same function.

why did you change the solution ?

Try it with a few small numbers on paper, and hopefully, you'll spot the pattern.

PHP fork to fix this issue and enable PHP 8.

JS fork:

• Enable node 18 (Mocha + Chai for assertion).
• Expand tests to fix this issue
• Edited description to fix this issue