Ad
  • Custom User Avatar

    This Kata took much longer than i thought for me to get it right, really enjoyed scratching my head and suffering to make it work.

  • Default User Avatar

    Thanks for the fix! My solution works now.

  • Custom User Avatar

    Some issues are not fixed still:

    • The situation when two people have the same name/initials but different letter case is not covered in the tests. The random tests should probably randomize letter case too.
    • Need more random tests than one?
  • Default User Avatar

    Hi, thank you for your detailed feedback, I've made an attempt to address your points, if you have time to check again?

    Thank you!

  • Default User Avatar

    Hi! Thanks for the feedback! I've just taken a look and realised I was unintentionally passing the same array to the user code, as I was to the test code. (Which means if you were manipulating the array, it would affect the test result)
    Hopefully I've fixed this now, could you try and submit your solution again and mark as resolved if this has fixed the issue for you?

    Thanks!

  • Default User Avatar

    I'm pretty sure the 'Should work for random names' test is bugged:

    TypeError: user.toLowerCase is not a function
        at /workspace/node/test.js:312:34
        at Array.map (<anonymous>)
        at solution (test.js:311:30)
        at Context.<anonymous> (test.js:305:52)
        at process.processImmediate (node:internal/timers:471:21)
    

    I've checked many times whether I was causing the error, but everything seemed fine on my part. It's preventing me from passing all the tests.

  • Default User Avatar

    Thank you!

  • Custom User Avatar

    Minor spelling mistakes in description

    • First Line: fed back -> feedback
    • Last line: alphebetised -> alphabetised
  • Custom User Avatar
    • The random test has a chance to generate the same fullname twice. No information in the description how to handle this situation. If duplicate names allowed, should be separate test for it, if not - they should not be generated.
    • No edge case for empty list.
    • The situation when two people have the same name/initials but different letter case is not covered in the tests. The random tests should probably randomize letter case too.
    • Need more random tests than one?
    • No information about used alphabet. It's assumed the names contain only A-Z letters, but not stated anywhere in the description.
  • Custom User Avatar

    Still not fixed in Example Test Cases

  • Default User Avatar

    Thanks for the feedback!

  • Custom User Avatar

    Resolved.

  • Custom User Avatar
    • truncateThreshold in chai config should be set to 0 or false so that the expected result is not truncated
    • No random tests