Great minds think alike ;-)

Me: create variables, use for loop, if else ... My opponent with his single code line:

Fixed. ;)

I upvoted on clever, because its very similar to my solution ;)

Why not?

I think he definitely did it cause it was fancier lol. There's no need to do it

Thanks for the feedback. I tried to fix the mistakes. Good coding!

Hi,

even if it's a puzzle, there are too much info lacking.

• missing puzzle tag
• no fixed tests in the full test suite
• random tests use float values
• the sample tests should specify correctly how to use Crit => crit.chance and crit.damage
• the expected values are rounded => do not round, use assert_approx_equal
• the sample tests are clearly insufficent: the user should have most of what's required to actually solve the task in thre. Currently:
  • 5 tests
  • 3 are trivial
  • only 2 are more or less useful (lst one is rather useless...) so it's impossible to figure out the pattern from them
  • only interger outputs => the fact that floats are involved isn't obvious

Cheers

My code is definitely bad, correct?)))

That's really smart.

beautiful

The most elegant solution I have seen