Ad
  • Custom User Avatar

    resolved

  • Custom User Avatar

    ok, I found the translation and approved it. Tests are updated accordingly. I didn't get description conflicts, so I hope everything is good...

    @Heathro: the changes of a translation are applied only when it's approved.

  • Custom User Avatar

    actually, working with forks can mess the things up too

    Oh ok. Good to know...

    but when I enter translation I see updated

    Is there a link to this updated fork? I don't think you can self-approve it (someone else should do it).

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    @Heathro: you saw my answer above? (the issue)

  • Custom User Avatar

    (actually, working with forks can mess the things up to, considering how the forking process is working right now, so... For now, there is no "best way"... Hopefully fixed in near future)

  • Custom User Avatar

    agreed. thank you. next time I will be professional :)

  • Custom User Avatar

    It was mine java translation

    Yes I noticed. It's not that bad in this case, and if you really know what you're doing, it's probably ok. But usually it's better to just work with a fork, so you don't accidently mess something up :P (you can see which lines you changed or removed)

  • Custom User Avatar

    na, that's ok if you're the translator.

  • Custom User Avatar

    It's okay for you to fix in editor as long as you know how and what to fix, then all good !!!

  • Custom User Avatar

    Nope, not at all.
    You have to work on a copy of the input in the ref solution.

    to be clearer: the very first line of code of the ref solution is mutating the input. That's the problem

  • Custom User Avatar

    oh. ok. It was mine java translation. wanted to fix it. sorry

  • Custom User Avatar

    Do NOT go around editing other users' katas. If there is an issue, you should raise one, or publish a fork with working tests, NOT editing the kata directly.

  • Custom User Avatar

    already sorted. thanks

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Loading more items...