Initial code is missing from the kata.
Random tests are missing too.
When decimal numbers are returned, they should be round to 8.
But in the random tests:
236333.43401918 should equal 236333.43401918001
Result shouldn't be rounded: it causes error that propagates through other calculations.
Also:
('S', 33, 27, 33.22440000000199) should equal ('S', 33.0, 27.0, 33.2244)
Test setup is wrong: one city is initialized with a tuple while the other is initialized with Coordinates object.
Coordinates
Haversine distance is a duplicate of https://www.codewars.com/kata/524ada2bdc2121b521000353
Python translation with adding assert_approx_equals and also other improvments (fixing typos in description, new test framework, etc)
assert_approx_equals
(the author is inactive)
Don't round results before comparision, use test.assert_approx_equals.
test.assert_approx_equals
See https://www.codewars.com/kata/5f9f43328a6bff002fa29eb8
Should mention in the description that some characters translate to multiple characters, and what exactly:
Æ
Ae
æ
ae
Þ
Th
þ
th
Also: ß --> B? Phonetically it's ss; but if you're translating the letters visually, then Þ should translate to b or p, not Th...
ß
B
ss
b
p
I do not understand this test case:
Testing 'C. Norris' and 'Carlos N.' True should equal False
True should equal False
To me it looks like they could belong to the same person
Needs random tests.
accents: could_be(E, é) : True
could_be(E, é) : True
Except that é is not tested.
é
Needs edge case could_be('?','!').
could_be('?','!')
Empty strings should not be considered a match, but it's not mentioned in the descriptions.
Description is incomplete: what are the list of accents that we need to handle? There are infinite amount of possible accents (see Zalgo).
No random tests.
Loading collection data...
Initial code is missing from the kata.
Random tests are missing too.
But in the random tests:
Result shouldn't be rounded: it causes error that propagates through other calculations.
Also:
Test setup is wrong: one city is initialized with a tuple while the other is initialized with
Coordinates
object.Haversine distance is a duplicate of https://www.codewars.com/kata/524ada2bdc2121b521000353
Python translation with adding
assert_approx_equals
and also other improvments (fixing typos in description, new test framework, etc)(the author is inactive)
Don't round results before comparision, use
test.assert_approx_equals
.See https://www.codewars.com/kata/5f9f43328a6bff002fa29eb8
Should mention in the description that some characters translate to multiple characters, and what exactly:
Æ
-->Ae
æ
-->ae
Þ
-->Th
þ
-->th
(this is a guess, haven't seen it in the tests)Also:
ß
-->B
? Phonetically it'sss
; but if you're translating the letters visually, thenÞ
should translate tob
orp
, notTh
...I do not understand this test case:
Testing 'C. Norris' and 'Carlos N.'
True should equal False
To me it looks like they could belong to the same person
Needs random tests.
Except that
é
is not tested.Needs edge case
could_be('?','!')
.Empty strings should not be considered a match, but it's not mentioned in the descriptions.
Description is incomplete: what are the list of accents that we need to handle? There are infinite amount of possible accents (see Zalgo).
No random tests.
Loading more items...