Ad
  • Custom User Avatar

    A couple optimizations are warranted:

    • Remove the last 2 lines of the code block in the description and add to the plain text description
    • You can implement the random string generator as (repeatedly len #(rand-nth "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz"), or something similar with rand-nth
  • Custom User Avatar
  • Custom User Avatar

    Good point. This now uses a list of candidate names to generate an input list of up to 100 names. Thank you!

  • Custom User Avatar

    I have difficulty reading LISP, but are you generating lists of completely random names for the random tests? Those would be very unlikely to include repeats.

    You should be generating lists of names picked randomly from a limited list, the way it's done in JS and Haskell ( I don't know how the C# original does it. I hope that doesn't generate completely random name lists either ).

  • Custom User Avatar

    Type issue in the test suite?

    test/CalculateParityBitSpec.hs:18:105: error:
    • Couldn't match expected type ‘Int’ with actual type ‘Word’
    • In the third argument of ‘assertEqual’, namely
    ‘(checkParity parity string)’
    In a stmt of a 'do' block:
    assertEqual
    ("checkParity " <> show parity <> " " <> show string)
    (refCheckParity parity string) (checkParity parity string)
    In the expression:
    do assertEqual
    ("checkParity " <> show parity <> " " <> show string)
    (refCheckParity parity string) (checkParity parity string)
    |
    18 | assertEqual ("checkParity " <> show parity <> " " <> show string) (refCheckParity parity string) (checkParity parity string)
    |
    ^^^^^^^^^^^^^^^^^^^^^^^^^

  • Custom User Avatar

    Ashamed that I didn't realize it was this simple...

  • Custom User Avatar

    The Scala function should return List[String], not List[String, String]