Ad
  • Custom User Avatar

    Great problem-solving skills!

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    How on earth did this get published?

  • Custom User Avatar

    I would like to change my Kata...

    Unfortunately, your kata was retired due to low satisfaction votes.

    ... so that each output type is an array. E.g. not a string if there's an empty array.

    This would be the correct decision. If there are no matches, that could be perfectly represented by an empty array.

    My sample tests only included edge cases of being empty arrays or not containing the relevant input type.

    You're confusing sample tests with submission tests.

    I should have included edge cases where the paramater "bin" was different data types from an array. E.g. string of random-ish characters or just integers.

    This is a bad idea as input validation would only distract the user from the main task. What I meant was that, at minimum, a test case with no matches should have been present in the sample tests.

    I don't think I included any random tests. I don't see what random tests I included?

    You didn't, that's the issue. Users could simply hardcode the expected outputs for your test cases to pass the kata. You should read the documentation on why both fixed tests and random tests are necessary.

    I can see why my Kata was similar to other trivial / filter kata, although I can think of multiple duplicate katas that were published which are similar in that they filter through arrays. I thought the subject matter I chose was sufficiently different however.

    It's good that your kata had an original backstory, but the task also needs to be novel. As I pointed out, there already are multiple trivial map/filter tasks.

    Thank you for your time in reviewing my kata.

    You're welcome. I recommend joining Codewars' discord server. There are dedicated channels where you can ask questions about codewars, including: solving kata, authoring kata, translating kata, kata ideas, etc.

    Good luck in your future kata.

  • Custom User Avatar

    Hi Nuno,

    Thank you for your feedback. I did think after reading the documentation that I fulfilled what was required. But that might speak to my lack of experience in coding and authoring Katas in general!

    I'd like to address your points in order:

    • I would like to change my Kata so that each output type is an array. E.g. not a string if there's an empty array.
    • My sample tests only included edge cases of being empty arrays or not containing the relevant input type. I can see now I should have included edge cases where the paramater "bin" was different data types from an array. E.g. string of random-ish characters or just integers.
    • I don't think I included any random tests. I don't see what random tests I included?
    • I can see why my Kata was similar to other trivial / filter kata, although I can think of multiple duplicate katas that were published which are similar in that they filter through arrays. I thought the subject matter I chose was sufficiently different however.

    I hope you don't see my replies as combative! I'm purely here to learn :) I will read the documentation and I am not expecting an answer tomy points.

    Thank you for your time in reviewing my kata.

  • Custom User Avatar

    Retired.

  • Custom User Avatar

    Hi,

    • There should only be a single output type
    • Sample tests should contain relevant edge cases
    • No random tests
    • Duplicate of any trivial map/filter kata

    If you're interested in authoring kata, you should read the relevant documentation before your next attempt.

  • Custom User Avatar

    This comment is hidden because it contains spoiler information about the solution

  • Custom User Avatar

    This was really fun to get my head around. Thanks for this solution

  • Custom User Avatar

    Use tr when you want to replace (translate) single characters.
    Use gsub when you need to use a regular expression or when you want to replace longer substrings

  • Custom User Avatar

    Why is it best practice to use .tr method here? Thanks for the great submission :D