Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
IMHO the fact that the tests (which are not random) failed with this exact message
AttributeError: 'PokemonType' object has no attribute 'name'
in casename
was not implemented clearly mean that the thing is tested for, and this should be marked as a Suggestion, not an issue. Btw I now have added 2 more explicit test cases.This comment is hidden because it contains spoiler information about the solution
ATTACK_MULTIPLIERS
so it is consistent that it contains details from an attacking POV. Flying attacks Ground with 1x damage (nothing to specify), while Ground attacks Flying with a 2x damage. This is not always the case that if Type_A does 2x dmg Type_B then Type_B does 0.5x dmg Type_A.test.expect
something) of the testing suiteHi, this time (to answer the "...again") I don't think you nail any real point tbh.
"Normal": {"Ghost": 0}
i.e. "Normal" does 0 damage to "Ghost".test.expect
nortest.assert_equals
without error description in the internal test case. If you found some other type of misleading error description please provide me something to watch for and I'll fix ittest.expect(PT.get("Ghost").is_immune_to("Normal"))
in the sample tests where users can add/comment out/edit as they need to (if they actually experience errors) is perfectly fine, readable and clear. I also don't thinktest.assert_equals
was properly used, as per your observation, since it missed the verbose description. I've still added message description for every error (bothexpect
andassert_equals
) in the example test case, althought they make the test case code box less clean and more annoying to edit for the users imo, but whatever.DefaultType
was declared this wayDefaultType = TypeVar("DefaultType")
meaning 'DefaultType is a generic type with name "DefaultType"'. I've still changed it toDefaultType = TypeVar("T")
to be even more clear that it's just a generic type used to specify that the return type ofget
should be eitherPokemonType
or any type thedefault
param is. I think that what's on my mind is also on the initial solution, so it doesn't really need to be verbosely explained. Do you really think I should explain this inside the description?PS I still wait for your response to mark the issue as solved
Nice catch, pretty coherent the bugs were in the Bug isn't it?
Fixed, thank you. I have also double checked others and didn't find any additional error.
This comment is hidden because it contains spoiler information about the solution
Is it 6 kyu appropriate iyo?
Mb, added in the description and fixed a broken test not accounting for it, should be trivial to adapt the solution
Solved 1, 2 and found that the 1 was not the only one non-int being fed by the test suite. Fixed everything. Thanks again for the feedback.
Can I ask you what's the kata difficulty tier in your opinion?
Done. Just trimmed the type details.
Ok, you're right, but it seems a doable tradeoff since the actual methods where
alpha
androi
should be used are provided. I think that it make sense to accept to not implement like it would be for a professional software operating in finance, if this make more readable for the already ultra-brave trainee and not having to also explaining him thatroi
andalpha
are to be seen as percentage integers representing a number with x decimals. The purpose of the kata is to have fun (mostly are not, but whatever, I'm a nerd) while understanding how a ponzi scheme could work internally from a high level POV.@hobovsky Everything is an integer now.
@uttumuttu I've changed the test suite, the solution and the initial solution + integrated the description. I've chose to simply provide the functions to be used to compute both monthly alpha and interests since, as you've pointed to, it's the only step where floats could slips into (assuming the implementation is correct). Thanks for your patience, I really appreciate your contributions that are strongly motivating
I've opted for a little bit of clarification in the description, since I think it's the simplest way to avoid explaining and implementing more mechanics (since the kata is already too much scaring as it is)
Description:
This comment is hidden because it contains spoiler information about the solution
@Mercy It's kind of my first serious attempt to author a kata, I'm not even sure about what I'm doing LOL! Btw I don't see any fancy stats
@Kacarott From a dev POV difficulty imo should be around 6 to 4 (i've proposed 5) because there is nothing expecial but some OOP and err handling. But yeah now I'm figuring out that from an implementation POV it could be way higher even if I thought the description had everything specified =/
PS where did you find the number of people training?
Loading more items...