done

.

Huh ?!?

Hi gabrielsiedler,

I thought it would be better if I did not literally translate the Kata method by method from JS to PHP to add in a little bit of variation in (and perhaps improve) the tests, but since I realise that this is your Kata, if you want the test cases modified, I will gladly do so. However, since I am quite busy for the following four weeks or so, I may not be able to edit the test cases immediately, and for that I sincerely apologise. I will be sure to modify the tests once I am available.

In the meantime, may you please help me take a look at the other 4 Kata translations in PHP I have made for this series? It would be greatly appreciated if you approved the other 4 PHP translations I have made for this series as I am desperately trying to increase the number of PHP Kata available on this site (and I poured in a lot of time and effort into each and every translation but that is another issue). However, if you do not like the translations and would like the test cases modified (as in this translation) feel free to provide feedback and suggestions but it would be greatly appreciated if you did not flat out reject them.

In case you lost the links to the other 4 translations here they are:

• PHP Translation for Kata #2 of this Series
• PHP Translation for Kata #3 of this Series
• PHP Translation for Kata #4 of this Series
• PHP Translation for Kata #5 of this Series

Thank you very much :D

Cheers,
donaldsebleung

Thanks for pointing it out. Added javascript example to the description.

Sure, in that case you need to validate spaces at the beginning and spaces at the end

Thanks for your issue. I`ve changed some tests(and added new), changed the name of the function, but I would like to leave the board 8x8 as it is now.

I guess at this point I will not change it. And having people find out that the object changes might be something good, they realize how they should write real tests...

Good catch.

Marking as resolved

To do that I think I would have to rewrite all tests. But that's a good suggestion.

But in the other hand, by testing the same instance people will realize previous tests are impacting the tests and learn something with it, I guess.

? It is in both the sample test cases and the regular test cases.

Done

Done that.