Loading collection data...
Collections are a way for you to organize kata so that you can create your own training routines. Every collection you create is public and automatically sharable with other warriors. After you have added a few kata to a collection you and others can train on the kata contained within the collection.
Get started now by creating a new collection.
assert_equals
should be usedThis comment is hidden because it contains spoiler information about the solution
The following test case is erroneous:
Though it is discouraged by ICANN, an e-mail address with no dot (using a local domain name) is still a valid e-mail address per RFC.
Needs random tests
Many of the tests require true/false values, whereas idiomatic Ruby allows for truthy and falsey values in situations like this. (The fact that some but not all of the tests require true/false makes failures even more confusing.) A number of previous comments on this kata seem to stem from this feature of the tests.
I would recommend changing all positive tests like
Test.expect(validate( 'joe.m@server.com') == true)
toTest.expect validate( 'joe.m@server.com')
and all negative tests likeTest.expect(validate( 'joe.m.k@server') == false)
toTest.expect !validate( 'joe.m.k@server')
.