hagi | Codewars

Name:Unknown

Clan:Unknown

Member Since:Jul 2014

Last Seen:Oct 2021

Profiles:

Following:0

Followers:0

Allies:0

View Profile Badges

- AlgernonTheMouse
- commented on "Sherlock on pockets" kata
pretty bad description, you say if pockets == nil i.e. if the first argument is nil, but what you really mean is if all the values in the hash are nil or empty arrays, or if the hash itself is empty.
- akar-0
- created an issue for "Sherlock on numbers" kata
This comment is hidden because it contains spoiler information about the solution
- Blind4Basics
- commented on "Sherlock on pockets" kata
- change the rank: nope, unless an admin goes by
- average was surprisingly high, even for pus... (old kata). Anyway...
- update: don't bother. Keeping the nil stuff will at least enforce something.
- daniloxxv
- commented on "Sherlock on pockets" kata
Eh, sorry, I wasn't getting notifications on this post for some reason and approved it before seeing your first comment. I published it with the power user average ranking (6kyu), since the overall average seemed a bit too high (5kyu). Are you sure it's too late to change the nil/empty array thing, though? The author's solution would have to be updated, but aside from that it's a minor change.
- Blind4Basics
- commented on "Sherlock on pockets" kata
no, that won't change anything since currently that's the user who's converting the nils to an empty array (I mean... If the user coded it in a clever way... 'XD ). But yeah, that's what beta phase is made for, so go ahead. That way, I won't have second thoughts when approving it to 7 kyus. ;)

EDIT: mmh damn... already approved... :( Then, keep it that way instead.
- daniloxxv
- commented on "Sherlock on pockets" kata
Agreed. I thought of doing that, but it would invalidate pretty much all of the existing solutions. Would that be ok?
- Blind4Basics
- commented on "Sherlock on pockets" kata
what do you think about removing pockets being nil and replace them with an empty array instead? That would make way more sense, imo.
- daniloxxv
- resolved an issue on "Sherlock on pockets" kata
- Added sample tests
- Fixed the code and description to change ints to single element arrays
- Blind4Basics
- created an issue for "Sherlock on pockets" kata
- missing sample tests
- the design of the pockets doesn't make sense: single items should be stored in a single element array
- Voile
- created an issue for "Sherlock in bookstore" kata
As far as the kata is right now the design is bad. Values of two semantics are mixed together with no way to tell between the both (not to mention exluding the option to have a price deduction of less than a dollar).
- Voile
- commented on "Sherlock in bookstore" kata
Bad kata design is still bad. Re-raising issue.
- Voile
- created an issue for "Sherlock in bookstore" kata
The result is suspect to floating point errors because no rounding is specified. e.g:
```
should return 1 for order {:all=>100} and coupon {:value=>-0.99} -  Expected: 1, instead got: 1.0000000000000009
```
- Voile
- created an issue for "Sherlock in bookstore" kata
Order value should not be negative and should be rounded to two decimal points.

The Order value should be rounded to two decimal points part is not tested.
- Voile
- commented on "Sherlock in bookstore" kata
Untrue. Gonna re-raise issue.
- cliffstamp
- resolved an issue on "Sherlock in bookstore" kata
Copied.

AlgernonTheMouse
commented on "Sherlock on pockets" kata

akar-0
created an issue for "Sherlock on numbers" kata

Blind4Basics
commented on "Sherlock on pockets" kata

daniloxxv
commented on "Sherlock on pockets" kata

Blind4Basics
commented on "Sherlock on pockets" kata

daniloxxv
commented on "Sherlock on pockets" kata

Blind4Basics
commented on "Sherlock on pockets" kata

daniloxxv
resolved an issue on "Sherlock on pockets" kata

Blind4Basics
created an issue for "Sherlock on pockets" kata

Voile
created an issue for "Sherlock in bookstore" kata

Voile
commented on "Sherlock in bookstore" kata

Voile
created an issue for "Sherlock in bookstore" kata

Voile
created an issue for "Sherlock in bookstore" kata

Voile
commented on "Sherlock in bookstore" kata

cliffstamp
resolved an issue on "Sherlock in bookstore" kata

Loading more items...

You have not created any collections yet.

AlgernonTheMousecommented on "Sherlock on pockets" kata

akar-0created an issue for "Sherlock on numbers" kata

Blind4Basicscommented on "Sherlock on pockets" kata

daniloxxvcommented on "Sherlock on pockets" kata

Blind4Basicscommented on "Sherlock on pockets" kata

daniloxxvcommented on "Sherlock on pockets" kata

Blind4Basicscommented on "Sherlock on pockets" kata

daniloxxvresolved an issue on "Sherlock on pockets" kata

Blind4Basicscreated an issue for "Sherlock on pockets" kata

Voilecreated an issue for "Sherlock in bookstore" kata

Voilecommented on "Sherlock in bookstore" kata

Voilecreated an issue for "Sherlock in bookstore" kata

Voilecreated an issue for "Sherlock in bookstore" kata

Voilecommented on "Sherlock in bookstore" kata

cliffstampresolved an issue on "Sherlock in bookstore" kata

Loading more items...

Confirm

Collect: kata

You have not created any collections yet.

AlgernonTheMouse
commented on "Sherlock on pockets" kata

akar-0
created an issue for "Sherlock on numbers" kata

Blind4Basics
commented on "Sherlock on pockets" kata

daniloxxv
commented on "Sherlock on pockets" kata

Blind4Basics
commented on "Sherlock on pockets" kata

daniloxxv
commented on "Sherlock on pockets" kata

Blind4Basics
commented on "Sherlock on pockets" kata

daniloxxv
resolved an issue on "Sherlock on pockets" kata

Blind4Basics
created an issue for "Sherlock on pockets" kata

Voile
created an issue for "Sherlock in bookstore" kata

Voile
commented on "Sherlock in bookstore" kata

Voile
created an issue for "Sherlock in bookstore" kata

Voile
created an issue for "Sherlock in bookstore" kata

Voile
commented on "Sherlock in bookstore" kata

cliffstamp
resolved an issue on "Sherlock in bookstore" kata